Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting OpenAI model in settings #1386

Merged
merged 5 commits into from
Dec 9, 2023

Conversation

aly-shehata
Copy link
Contributor

@aly-shehata aly-shehata commented Dec 8, 2023

@imartinez This PR allows setting the Open AI model to use in settings as proposed here https://github.com/users/imartinez/projects/3?pane=issue&itemId=44266044. Please feel free to update the board, and let me know if you have any feedback.

Copy link
Contributor

github-actions bot commented Dec 8, 2023

Copy link
Contributor

github-actions bot commented Dec 8, 2023

Copy link
Contributor

github-actions bot commented Dec 8, 2023

Copy link
Collaborator

@imartinez imartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also include this information in the docs, in fern/docs/pages/manual/llms.mdx

settings.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Dec 9, 2023

@aly-shehata
Copy link
Contributor Author

I ran make check and no issues were identified for this PR. @imartinez when you have a chance, please review. Thanks!

@imartinez imartinez marked this pull request as ready for review December 9, 2023 18:40
@imartinez imartinez merged commit a072a40 into zylon-ai:main Dec 9, 2023
8 checks passed
simonbermudez pushed a commit to simonbermudez/saimon that referenced this pull request Feb 24, 2024
feat(settings): Allow setting openai model to be used. Default to GPT 3.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants